ci: update GitHub Actions to Node 24 before June 2 deadline by estebany-qd · Pull Request #633 · qdrant/fastembed

estebany-qd · 2026-05-19T21:00:47Z

Summary

GitHub will force all JavaScript-based actions to run on Node 24 starting June 2, 2026.
Node 20 will be removed from runners entirely on September 16, 2026.

Actions pinned to older versions (v1-v4 for checkout, v2-v5 for setup-python, etc.) were
written for Node 12/16/20 and risk breaking when forced to Node 24.

This PR updates all actions/* references to the latest Node 24-native versions.

Changes

Action	From	To	Node
actions/checkout	v1-v4	v6.0.2	24
actions/setup-python	v2-v5	v6.2.0	24
actions/setup-node	v2-v4	v6.4.0	24
actions/setup-go	v4-v5	v6.4.0	24
actions/setup-java	v3	v5.2.0	24
actions/setup-dotnet	v4	v5.2.0	24
actions/cache	v3-v4	v5.0.5	24
actions/upload-artifact	v4	v7.0.1	24
actions/download-artifact	v4-v5	v8.0.1	24
actions/github-script	v7	v9.0.0	24

All target SHAs verified against their tags via the GitHub API.
All target versions confirmed running node24 in their action.yml.

References

https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

coderabbitai · 2026-05-19T21:02:37Z

📝 Walkthrough

Walkthrough

This PR updates pinned GitHub Actions versions across four workflow files in the repository. actions/checkout is upgraded to v6.0.2 and actions/setup-python is upgraded to v6.2.0 in the CI workflow, deployment workflow, test workflow, and type-checking workflow. No workflow logic, job structure, or command steps are modified; only the pinned action references are changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main objective of the PR: updating GitHub Actions to Node 24 versions before the June 2, 2026 deadline, which is the central purpose of the changeset.
Description check	✅ Passed	The description is comprehensive and directly related to the changeset, providing context about GitHub's Node 24 enforcement deadline and documenting all action version updates with verification details.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ci/estebany/update-actions-node24

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 zizmor (1.25.2)

.github/workflows/ci.yml

INFO zizmor: 🌈 zizmor v1.25.2
INFO audit: zizmor: 🌈 completed .github/workflows/ci.yml
[
{
"ident": "artipacked",
"desc": "credential persistence through GitHub Actions artifacts",
"url": "https://docs.zizmor.sh/audits/#artipacked",
"determinations": {
"confidence": "Low",
"severity": "Medium",
"persona": "Regular"
},
"locations": [
{
"symbolic": {
"key": {
"Local": {
"prefix": null,
"given_path": ".github/workflows/ci.yml"
}
},
"annotation": "does not set persist-credentials: false",
"route": {
"route": [
{
"Key": "jobs"
},
{
"Key": "deploy"
},
{
"Key": "steps"
},
{
"Index": 0
}
]
},
"feature_kind": "Normal",
"kind": "Primary"
},
"concrete": {
"location": {
"start_point": {
"row": 12,
"column": 8
},
"end_point": {
"row": 12,
"column": 80
},
"offset_span": {
"start": 156,
"end": 228
}
},
"feature": "uses: actions/checkout@de0fac2 # v6.0.2",
"comments": [
"# v6.0.2"
]
}
}
],
"ignored": false
}
]

.github/workflows/python-tests.yml

INFO zizmor: 🌈 zizmor v1.25.2
INFO audit: zizmor: 🌈 completed .github/workflows/python-tests.yml
[
{
"ident": "artipacked",
"desc": "credential persistence through GitHub Actions artifacts",
"url": "https://docs.zizmor.sh/audits/#artipacked",
"determinations": {
"confidence": "Low",
"severity": "Medium",
"persona": "Regular"
},
"locations": [
{
"symbolic": {
"key": {
"Local": {
"prefix": null,
"given_path": ".github/workflows/python-tests.yml"
}
},
"annotation": "does not set persist-credentials: false",
"route": {
"route": [
{
"Key": "jobs"
},
{
"Key": "test"
},
{
"Key": "steps"
},
{
"Index": 0
}
]
},
"feature_kind":

... [truncated 5154 characters] ...

uses: actions/checkout@de0fac2 # v6.0.2\n - name: Set up Python\n uses: actions/setup-python@a309ff8 # v6.2.0\n with:\n python-version: ${{ matrix.python-version }}\n - name: Install dependencies\n run: |\n python -m pip install poetry\n poetry config virtualenvs.create false\n poetry install --no-interaction --no-ansi --without dev,docs\n\n - name: Run pytest\n env:\n HF_TOKEN: ${{ secrets.HF_TOKEN }}\n run: |\n poetry run pytest",
"comments": [
"# Exclude 3.10–3.12 for macOS and Windows",
"# v6.0.2",
"# v6.2.0"
]
}
}
],
"ignored": false
}
]

.github/workflows/type-checkers.yml

INFO zizmor: 🌈 zizmor v1.25.2
INFO audit: zizmor: 🌈 completed .github/workflows/type-checkers.yml
[
{
"ident": "artipacked",
"desc": "credential persistence through GitHub Actions artifacts",
"url": "https://docs.zizmor.sh/audits/#artipacked",
"determinations": {
"confidence": "Low",
"severity": "Medium",
"persona": "Regular"
},
"locations": [
{
"symbolic": {
"key": {
"Local": {
"prefix": null,
"given_path": ".github/workflows/type-checkers.yml"
}
},
"annotation": "does not set persist-credentials: false",
"route": {
"route": [
{
"Key": "jobs"
},
{
"Key": "build"
},
{
"Key": "steps"
},
{
"Index": 0
}
]
},
"feature_kind

... [truncated 4204 characters] ...

on-version }}\n uses: actions/setup-python@a309ff8 # v6.2.0\n with:\n python-version: ${{ matrix.python-version }}\n\n - name: Install dependencies\n run: |\n python -m pip install --upgrade pip poetry\n poetry install --no-interaction --no-ansi --without dev,docs,test\n\n - name: mypy\n run: |\n poetry run mypy fastembed \\n --disallow-incomplete-defs \\n --disallow-untyped-defs \\n --disable-error-code=import-untyped\n\n - name: pyright\n run: |\n poetry run pyright tests/type_stub.py",
"comments": [
"# v6.0.2",
"# v6.2.0"
]
}
}
],
"ignored": false
}
]

1 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/ci.yml (1)
18-18: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Incomplete Node 24 migration: actions/cache still on v3.5.0.

According to the PR objectives, actions/cache should be updated from v3–v4 to v5.0.5 to ensure Node 24 compatibility before the June 2, 2026 deadline. The current v3.5.0 version may break when Node 20 is removed from runners.
🔄 Proposed fix
-      - uses: actions/cache@6f8efc29b200d32929f49075959781ed54ec270c # v3.5.0
+      - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v5.0.5
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 18, The workflow is still pinning
actions/cache to v3.5.0 which prevents Node 24 compatibility; update the
actions/cache usage (the line with "uses: actions/cache@...") to the v5 stable
tag (actions/cache@v5.0.5) so the CI uses the Node-24-compatible cache action;
verify no other workflow steps depend on v3 behavior and run the CI to confirm
the update succeeds.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/ci.yml:
- Line 18: The workflow is still pinning actions/cache to v3.5.0 which prevents
Node 24 compatibility; update the actions/cache usage (the line with "uses:
actions/cache@...") to the v5 stable tag (actions/cache@v5.0.5) so the CI uses
the Node-24-compatible cache action; verify no other workflow steps depend on v3
behavior and run the CI to confirm the update succeeds.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62c390b6-40f6-48f2-9dcc-2dfbf3ba2c76

📥 Commits

Reviewing files that changed from the base of the PR and between adfc1ae and b68b8cb.

📒 Files selected for processing (4)

.github/workflows/ci.yml
.github/workflows/python-publish.yml
.github/workflows/python-tests.yml
.github/workflows/type-checkers.yml

ci: update github actions to node 24

b68b8cb

coderabbitai Bot reviewed May 19, 2026

View reviewed changes

joein approved these changes May 20, 2026

View reviewed changes

joein merged commit fde1e0b into main May 20, 2026
13 checks passed

joein deleted the ci/estebany/update-actions-node24 branch May 20, 2026 09:33

coderabbitai Bot mentioned this pull request May 21, 2026

ci: fix remaining GitHub Actions on Node 20 #634

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: update GitHub Actions to Node 24 before June 2 deadline#633

ci: update GitHub Actions to Node 24 before June 2 deadline#633
joein merged 1 commit into
mainfrom
ci/estebany/update-actions-node24

estebany-qd commented May 19, 2026

Uh oh!

coderabbitai Bot commented May 19, 2026

Walkthrough

Estimated code review effort

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

estebany-qd commented May 19, 2026

Summary

Changes

References

Uh oh!

coderabbitai Bot commented May 19, 2026

Walkthrough

Estimated code review effort

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants